Review Board 1.7.22


SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

Review Request #11983 - Created June 20, 2013 and submitted

Mengwei Ding
SQOOP-675
Reviewers
Sqoop
abe, hshreedharan, jarcec
sqoop-sqoop2
commit 93eeb1225d6be0d95783ce6da5b8fd6e3d9fe986
Author: Mengwei Ding <mengwei.ding@cloudera.com>
Date:   Wed Jun 19 17:56:57 2013 -0700

    SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

:100644 100644 944fb49... d96f44e... M	client/src/main/java/org/apache/sqoop/client/core/ClientError.java
:100644 100644 085fcdb... b7b0436... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 83f1c4f... aa87f20... M	client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
:000000 100644 0000000... 7293f56... A	client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
:000000 100644 0000000... 2e1c8d3... A	client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java
:000000 100644 0000000... 5aab035... A	client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
:000000 100644 0000000... b854a90... A	client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java
:000000 100644 0000000... 154c58e... A	client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
:000000 100644 0000000... 49ab461... A	client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java
:100644 000000 993bbde... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
:100644 000000 04bcf45... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
:100644 000000 29144d1... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
:100644 000000 c407d01... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
:100644 100644 a27d246... 5537a8e... M	client/src/main/resources/client-resource.properties
:100644 100644 a14898f... 22d6d47... M	docs/src/site/sphinx/CommandLineClient.rst
Done several manual test for all these 3 commands and their options.
client/src/main/java/org/apache/sqoop/client/core/Constants.java
Revision 06f8162 New Change
[20] 88 lines
[+20] [+] public class Constants {
89
  public static final String CMD_SET_SC = "\\st";
89
  public static final String CMD_SET_SC = "\\st";
90

    
   
90

   
91
  public static final String CMD_SHOW = "show";
91
  public static final String CMD_SHOW = "show";
92
  public static final String CMD_SHOW_SC = "\\sh";
92
  public static final String CMD_SHOW_SC = "\\sh";
93

    
   
93

   
94
  public static final String CMD_SUBMISSION = "submission";

   
95
  public static final String CMD_SUBMISSION_SC = "\\sub";

   
96

    
   

   
97
  public static final String CMD_UPDATE = "update";
94
  public static final String CMD_UPDATE = "update";
98
  public static final String CMD_UPDATE_SC = "\\up";
95
  public static final String CMD_UPDATE_SC = "\\up";
99

    
   
96

   

    
   
97
  public static final String CMD_START = "start";

    
   
98
  public static final String CMD_START_SC = "\\sta";

    
   
99

   

    
   
100
  public static final String CMD_STOP = "stop";

    
   
101
  public static final String CMD_STOP_SC = "\\stp";

    
   
102

   

    
   
103
  public static final String CMD_STATUS = "status";

    
   
104
  public static final String CMD_STATUS_SC = "\\stu";

    
   
105

   
100
  public static final String FN_CONNECTION = "connection";
106
  public static final String FN_CONNECTION = "connection";
101
  public static final String FN_JOB = "job";
107
  public static final String FN_JOB = "job";
102
  public static final String FN_SUBMISSION = "submission";
108
  public static final String FN_SUBMISSION = "submission";
103
  public static final String FN_SERVER = "server";
109
  public static final String FN_SERVER = "server";
104
  public static final String FN_OPTION = "option";
110
  public static final String FN_OPTION = "option";
105
  public static final String FN_CONNECTOR = "connector";
111
  public static final String FN_CONNECTOR = "connector";
106
  public static final String FN_VERSION = "version";
112
  public static final String FN_VERSION = "version";
107
  public static final String FN_FRAMEWORK = "framework";
113
  public static final String FN_FRAMEWORK = "framework";
108
  public static final String FN_START = "start";

   
109
  public static final String FN_STOP = "stop";

   
110
  public static final String FN_STATUS = "status";

   
111

    
   
114

   
112
  public static final String PRE_CLONE = "Clone";
115
  public static final String PRE_CLONE = "Clone";
113
  public static final String PRE_CREATE = "Create";
116
  public static final String PRE_CREATE = "Create";
114
  public static final String PRE_DELETE = "Delete";
117
  public static final String PRE_DELETE = "Delete";
115
  public static final String PRE_SET = "Set";
118
  public static final String PRE_SET = "Set";
116
  public static final String PRE_SHOW = "Show";
119
  public static final String PRE_SHOW = "Show";
117
  public static final String PRE_SUBMISSION = "Submission";

   
118
  public static final String PRE_UPDATE = "Update";
120
  public static final String PRE_UPDATE = "Update";

    
   
121
  public static final String PRE_START = "Start";

    
   
122
  public static final String PRE_STATUS = "Status";

    
   
123
  public static final String PRE_STOP = "Stop";
119
  public static final String SUF_INFO = "Info";
124
  public static final String SUF_INFO = "Info";
120

    
   
125

   
121

    
   
126

   
122
  public static final String PROP_HOMEDIR = "user.home";
127
  public static final String PROP_HOMEDIR = "user.home";
123
  public static final String PROP_CURDIR = "user.dir";
128
  public static final String PROP_CURDIR = "user.dir";
[+20] [20] 185 lines
[+20] public class Constants {
309
  public static final String RES_SHOW_PROMPT_VERSION_CLIENT_SERVER =
314
  public static final String RES_SHOW_PROMPT_VERSION_CLIENT_SERVER =
310
      "show.prompt_version_client_server";
315
      "show.prompt_version_client_server";
311
  public static final String RES_SHOW_PROMPT_VERSION_PROTOCOL =
316
  public static final String RES_SHOW_PROMPT_VERSION_PROTOCOL =
312
      "show.prompt_version_protocol";
317
      "show.prompt_version_protocol";
313

    
   
318

   

    
   
319
  public static final String RES_START_USAGE =

    
   
320
      "start.usage";

    
   
321
  public static final String RES_START_DESCRIPTION =

    
   
322
      "start.description";

    
   
323
  public static final String RES_START_MESSAGE =

    
   
324
      "start.message";

    
   
325

   

    
   
326
  public static final String RES_STATUS_USAGE =

    
   
327
      "status.usage";

    
   
328
  public static final String RES_STATUS_DESCRIPTION =

    
   
329
      "status.description";

    
   
330
  public static final String RES_STATUS_MESSAGE =

    
   
331
      "status.message";

    
   
332
  public static final String RES_PROMPT_SYNCHRONOUS =

    
   
333
      "start.prompt_synchronous";

    
   
334

   

    
   
335
  public static final String RES_STOP_USAGE =

    
   
336
      "stop.usage";

    
   
337
  public static final String RES_STOP_DESCRIPTION =

    
   
338
      "stop.description";

    
   
339
  public static final String RES_STOP_MESSAGE =

    
   
340
      "stop.message";

    
   
341

   
314
  public static final String RES_SQOOP_SHELL_BANNER =
342
  public static final String RES_SQOOP_SHELL_BANNER =
315
      "sqoop.shell_banner";
343
      "sqoop.shell_banner";
316
  public static final String RES_SQOOP_PROMPT_SHELL_LOADRC =
344
  public static final String RES_SQOOP_PROMPT_SHELL_LOADRC =
317
      "sqoop.prompt_shell_loadrc";
345
      "sqoop.prompt_shell_loadrc";
318
  public static final String RES_SQOOP_PROMPT_SHELL_LOADEDRC =
346
  public static final String RES_SQOOP_PROMPT_SHELL_LOADEDRC =
319
      "sqoop.prompt_shell_loadedrc";
347
      "sqoop.prompt_shell_loadedrc";
320

    
   
348

   
321
  public static final String RES_SUBMISSION_USAGE =

   
322
      "submission.usage";

   
323
  public static final String RES_PROMPT_SYNCHRONOUS =

   
324
      "submission.prompt_synchronous";

   
325

    
   

   
326
  public static final String RES_UPDATE_USAGE =
349
  public static final String RES_UPDATE_USAGE =
327
      "update.usage";
350
      "update.usage";
328
  public static final String RES_UPDATE_UPDATING_CONN =
351
  public static final String RES_UPDATE_UPDATING_CONN =
329
      "update.conn";
352
      "update.conn";
330
  public static final String RES_UPDATE_CONN_SUCCESSFUL =
353
  public static final String RES_UPDATE_CONN_SUCCESSFUL =
[+20] [20] 82 lines
client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
Revision 83f1c4f New Change
 
client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
New File
 
client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java
New File
 
client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
New File
 
client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java
New File
 
client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
New File
 
client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java
New File
 
client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
Revision 993bbde New Change
 
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
Revision 04bcf45 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
Revision 29144d1 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
Revision c407d01 New Change
 
client/src/main/resources/client-resource.properties
Revision 8a570a1 New Change
 
docs/src/site/sphinx/CommandLineClient.rst
Revision a14898f New Change
 
  1. client/src/main/java/org/apache/sqoop/client/core/Constants.java: Loading...
  2. client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java: Loading...
  3. client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java: Loading...
  4. client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java: Loading...
  5. client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java: Loading...
  6. client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java: Loading...
  7. client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java: Loading...
  8. client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java: Loading...
  9. client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java: Loading...
  10. client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java: Loading...
  11. client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java: Loading...
  12. client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java: Loading...
  13. client/src/main/resources/client-resource.properties: Loading...
  14. docs/src/site/sphinx/CommandLineClient.rst: Loading...