Fix for SQOOP-934: Potential connection timeout
Review Request #11940 - Created June 18, 2013 and submitted
This patches fixes the SQOOP-934. The connection created prior to map-reduce job can potentially timed out while the job is running. This will cause problems when this connection is reused for generating the hive script. This patch discards the connection prior to hive script generation. So, a fresh connection will be used for generating hive script.
Unit tests pass. Manually tested hive import.
Posted (June 19, 2013, 2:32 a.m.)
Hi Raghav, thank you very much for taking up this one!
Just brainstorming here, would it make sense to use Connection.isValid()  and discard the connection only in case that it's invalid? Rather than discarding even valid connection? (Such code would have to be in the ConnectionManager of course) Links: 1: http://docs.oracle.com/javase/6/docs/api/java/sql/Connection.html#isValid(int)
I'm afraid that adding new abstract method to ConnManager is backward incompatible change. We should provide default implementation throwing NotImplementedException or something similar in the ConnManager class.
Review request changed
Updated (June 21, 2013, 6 p.m.)
- changed from pending to submitted