Review Board 1.7.22


SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

Review Request #11920 - Created June 17, 2013 and submitted

Mengwei Ding
SQOOP-971
Reviewers
Sqoop
abe, hshreedharan, jarcec
sqoop-sqoop2
commit 8f40d46cf416979271058a21d45c328710608624
Author: Jarek Jarcec Cecho <jarcec@apache.org>
Date:   Thu Jun 20 15:02:56 2013 -0700

    SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

:100644 100644 500189a... 0540f6b... M	core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
:100644 100644 f59d132... eb7c1dc... M	core/src/main/java/org/apache/sqoop/core/CoreError.java
:000000 100644 0000000... d25ce41... A	core/src/main/java/org/apache/sqoop/core/Reconfigurable.java
:100644 100644 deb24c9... 13bbfc2... M	core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java
:100644 100644 84896d6... 90bb327... M	core/src/main/java/org/apache/sqoop/core/SqoopServer.java
:100644 100644 145a2c1... a81306b... M	core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
:000000 100644 0000000... 9e90cac... A	core/src/main/java/org/apache/sqoop/framework/JobManager.java
:100644 100644 3339c59... e709975... M	core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java
:100644 100644 955306d... d35b080... M	core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java
:100644 100644 4ea52e9... 1ec6bdf... M	core/src/main/java/org/apache/sqoop/repository/RepositoryProvider.java
:100644 100644 de9a24b... b61a6d6... M	server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java

 
Total:
9
Open:
1
Resolved:
8
Dropped:
0
Status:
From:
Description From Last Updated Status
There seems to be duplicity with similar code fragment in initialize() method, maybe it's worth abstracting into a method? Jarek Cecho June 18, 2013, 2:51 p.m. Open
Review request changed
Updated (June 24, 2013, 4:21 p.m.)
  • changed from pending to submitted