Review Board 1.7.22


Jarek Cecho got review request #11911!

SQOOP-1087 Sqoop2: Integration: Abstract common functionality into src module

Review Request #11911 - Created June 17, 2013 and submitted

Jarek Cecho
SQOOP-1087
Reviewers
Sqoop
sqoop-sqoop2
I've cut the interesting methods into standalone packages/classes, so that any third party code can easily reuse them. I've also moved the test cases into the src package, so they can also be easily reused. The test package is currently used only for the integration tests themselves.
Integration tests are passing.
test/pom.xml
Revision b7ea1ed5716d082239eed98849fb4ca1c4d6e4a4 New Change
[20] 30 lines
[+20]
31

    
   
31

   
32
  <dependencies>
32
  <dependencies>
33
    <dependency>
33
    <dependency>
34
      <groupId>junit</groupId>
34
      <groupId>junit</groupId>
35
      <artifactId>junit</artifactId>
35
      <artifactId>junit</artifactId>
36
      <scope>test</scope>

   
37
    </dependency>
36
    </dependency>
38

    
   
37

   
39
    <dependency>
38
    <dependency>
40
      <groupId>org.apache.sqoop</groupId>
39
      <groupId>org.apache.sqoop</groupId>
41
      <artifactId>sqoop-core</artifactId>
40
      <artifactId>sqoop-core</artifactId>
[+20] [20] 289 lines
test/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.java
New File
 
test/src/main/java/org/apache/sqoop/test/asserts/ProviderAsserts.java
New File
 
test/src/main/java/org/apache/sqoop/test/data/Cities.java
New File
 
test/src/main/java/org/apache/sqoop/test/data/DataSet.java
New File
 
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java
New File
 
test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java
New File
 
test/src/main/java/org/apache/sqoop/test/utils/HdfsUtils.java
New File
 
test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java
Revision fa2c2b467d3a252ff54728762a7e96fbb4fbc9af New Change
 
test/src/test/java/org/apache/sqoop/integration/connector/ConnectorTestCase.java
Revision d4e432de12e7768bc0b111e7e5942b8f22edd7a1 New Change
 
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableExportTest.java
Revision b920655ef46902d1c937748f9b78e3f1b491ebf3 New Change
 
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java
Revision adcfbaf895586a216f196380176dcae25017e646 New Change
 
test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java
Revision 0f48a8b6fe7b94e32e5a894bd33b653c6f6d1583 New Change
 
  1. test/pom.xml: Loading...
  2. test/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.java: Loading...
  3. test/src/main/java/org/apache/sqoop/test/asserts/ProviderAsserts.java: Loading...
  4. test/src/main/java/org/apache/sqoop/test/data/Cities.java: Loading...
  5. test/src/main/java/org/apache/sqoop/test/data/DataSet.java: Loading...
  6. test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java: Loading...
  7. test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java: Loading...
  8. test/src/main/java/org/apache/sqoop/test/utils/HdfsUtils.java: Loading...
  9. test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java: Loading...
  10. test/src/test/java/org/apache/sqoop/integration/connector/ConnectorTestCase.java: Loading...
  11. test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableExportTest.java: Loading...
  12. test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java: Loading...
  13. test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java: Loading...