Review Board 1.7.22


Sravya Tirukkovalur got review request #11811!

JMX support for HTTP Source.

Review Request #11811 - Created June 11, 2013 and submitted

Sravya Tirukkovalur
FLUME-2076
Reviewers
Flume
brocknoland, hshreedharan, mpercy
flume-git
Http Source supports following metrics:
START
STOP
OPEN_CONNECTION_COUNT
EVENTS_RECEIVED
EVENTS_ACCEPTED

Some points for discussion:
1. Should we support APPEND_BATCH_RECEIVED and APPEND_BATCH_ACCEPTED ?
Http doesnt have a batch setting, but multiple events can be sent in a single POST request. 
2. Is EVENTS_RECEIVED always same as APPEND_RECEIVED? 
Went over all the sources which support jmx metrics and it looks like they are redundant and never actually used separately.
Ran existing tests
Total:
1
Open:
1
Resolved:
0
Dropped:
0
Status:
From:
Review request changed
Updated (July 18, 2013, 12:05 a.m.)
  • changed from pending to submitted