Review Board 1.7.22


DRILL-45: Add builders for PlanProperties, LogicalPlan, Store and Scan

Review Request #11783 - Created June 10, 2013 and updated

Ben Becker
Reviewers
drill-git
jacques
drill-git
Looking for validation of builder apprach.
 - Includes LogicalPlanBuilder and PlanPropertiesBuilder attached to JIRA-45; rebased to latest execwork.
 - Includes ScanBuilder and StoreBuilder as well.

Note: One of the original builders also had a 'toBuilder()' method.  Is that something we should add for all builders?

 
common/src/main/java/org/apache/drill/common/PlanProperties.java
Revision 637dd66 New Change
This file was deleted. The content cannot be displayed.
common/src/main/java/org/apache/drill/common/logical/LogicalPlan.java
Revision 868f9ba New Change
 
common/src/main/java/org/apache/drill/common/logical/LogicalPlanBuilder.java
New File
 
common/src/main/java/org/apache/drill/common/logical/PlanProperties.java
New File
 
common/src/main/java/org/apache/drill/common/logical/data/Scan.java
Revision 9c315ff New Change
 
common/src/main/java/org/apache/drill/common/logical/data/ScanBuilder.java
New File
 
common/src/main/java/org/apache/drill/common/logical/data/Store.java
Revision bc34cc7 New Change
 
common/src/main/java/org/apache/drill/common/logical/data/StoreBuilder.java
New File
 
common/src/test/resources/storage_engine_plan.json
Revision efde80d New Change
 
exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java
Revision c09af88 New Change
 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/PhysicalPlan.java
Revision 7349dad New Change
 
sandbox/prototype/common/src/test/java/org/apache/drill/common/logical/LogicalPlanBuilderTest.java
New File
 
sandbox/prototype/common/src/test/java/org/apache/drill/common/logical/data/ScanBuilderTest.java
New File
 
sandbox/prototype/common/src/test/java/org/apache/drill/common/logical/data/StoreBuilderTest.java
New File
 
sqlparser/src/test/java/org/apache/drill/jdbc/test/JdbcTest.java
Revision 7574c2c New Change
 
  1. common/src/main/java/org/apache/drill/common/PlanProperties.java: Loading...
  2. common/src/main/java/org/apache/drill/common/logical/LogicalPlan.java: Loading...
  3. common/src/main/java/org/apache/drill/common/logical/LogicalPlanBuilder.java: Loading...
  4. common/src/main/java/org/apache/drill/common/logical/PlanProperties.java: Loading...
  5. common/src/main/java/org/apache/drill/common/logical/data/Scan.java: Loading...
  6. common/src/main/java/org/apache/drill/common/logical/data/ScanBuilder.java: Loading...
  7. common/src/main/java/org/apache/drill/common/logical/data/Store.java: Loading...
  8. common/src/main/java/org/apache/drill/common/logical/data/StoreBuilder.java: Loading...
  9. common/src/test/resources/storage_engine_plan.json: Loading...
  10. exec/java-exec/src/main/java/org/apache/drill/exec/opt/BasicOptimizer.java: Loading...
  11. exec/java-exec/src/main/java/org/apache/drill/exec/physical/PhysicalPlan.java: Loading...
  12. sandbox/prototype/common/src/test/java/org/apache/drill/common/logical/LogicalPlanBuilderTest.java: Loading...
  13. sandbox/prototype/common/src/test/java/org/apache/drill/common/logical/data/ScanBuilderTest.java: Loading...
  14. sandbox/prototype/common/src/test/java/org/apache/drill/common/logical/data/StoreBuilderTest.java: Loading...
  15. sqlparser/src/test/java/org/apache/drill/jdbc/test/JdbcTest.java: Loading...