Review Board 1.7.22


SQOOP-1067 Sqoop2: Tests should not use /tmp/ directory for storing data

Review Request #11614 - Created June 4, 2013 and submitted

Jarek Cecho
SQOOP-1067
Reviewers
Sqoop
sqoop-sqoop2
I've propagated maven build directory into the tests and use that instead of hardcoded /tmp/.
Integration and unit tests seems to be passing.
execution/mapreduce/pom.xml
Revision a6299e1ae8b3f13a40d2be924b8bd35a4a0518a1 New Change
[20] 48 lines
[+20]
49

    
   
49

   
50
    <!-- See profiles for Hadoop specific dependencies -->
50
    <!-- See profiles for Hadoop specific dependencies -->
51

    
   
51

   
52
  </dependencies>
52
  </dependencies>
53

    
   
53

   
54
  <!-- Add classifier name to the JAR name -->

   
55
  <build>
54
  <build>

    
   
55
    <!-- Add classifier name to the JAR name -->
56
    <plugins>
56
    <plugins>
57
      <plugin>
57
      <plugin>
58
        <groupId>org.apache.maven.plugins</groupId>
58
        <groupId>org.apache.maven.plugins</groupId>
59
        <artifactId>maven-jar-plugin</artifactId>
59
        <artifactId>maven-jar-plugin</artifactId>
60
        <version>2.4</version>
60
        <version>2.4</version>
61
        <configuration>
61
        <configuration>
62
          <classifier>hadoop${hadoop.profile}</classifier>
62
          <classifier>hadoop${hadoop.profile}</classifier>
63
        </configuration>
63
        </configuration>
64
      </plugin>
64
      </plugin>

    
   
65

   

    
   
66
      <!--

    
   
67
        Propagate our build directory to the tests

    
   
68
      -->

    
   
69
      <plugin>

    
   
70
        <groupId>org.apache.maven.plugins</groupId>

    
   
71
        <artifactId>maven-surefire-plugin</artifactId>

    
   
72
        <configuration>

    
   
73
          <systemPropertyVariables>

    
   
74
            <maven.build.directory>${project.build.directory}</maven.build.directory>

    
   
75
          </systemPropertyVariables>

    
   
76
        </configuration>

    
   
77
      </plugin>

    
   
78

   
65
    </plugins>
79
    </plugins>
66
  </build>
80
  </build>
67

    
   
81

   
68
  <!-- Profiles for various supported Hadoop distributions -->
82
  <!-- Profiles for various supported Hadoop distributions -->
69
  <profiles>
83
  <profiles>
[+20] [20] 66 lines
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java
Revision b3e605096f762a6746a137f46c26ac8650a75989 New Change
 
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java
Revision 14591b4144c7c807f6cbb70e658b36781af9f4fb New Change
 
  1. execution/mapreduce/pom.xml: Loading...
  2. execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java: Loading...
  3. execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java: Loading...