Review Board 1.7.22


Fix for SQOOP-1013

Review Request #11537 - Created May 30, 2013 and updated

Venkat Ranganathan
Reviewers
Sqoop
sqoop-sqoop2
This addresses Boolean, date, time, and timestamp splitters.

THis also disallows char type splitters as discussed in SQOOP-976
Introduced new unit tests to test new functionality
All tests pass
Review request changed
Updated (June 13, 2013, 5:46 a.m.)
Fixed the base in coverstion to a large enough value to allow for all possible Unicode code points.   Fixed iterating through the String to properly handle codepoints
Ship it!
Posted (June 13, 2013, 7 p.m.)
Looks good to me!
Seems right. Nit: 2097152 can be represented as a hex literal: 0x200000. Might be easier to see.
Posted (June 13, 2013, 8:32 p.m.)

   

  
Thanks Abraham.   Good point.  Even though the comments mention the choice of the value, it can be more prominent.   When we revisit this as part of the follow on JIRA, we can do that
Ship it!
Posted (June 13, 2013, 8:35 p.m.)
Ship It!