Review Board 1.7.22


SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://localhost:12000/sqoop'

Review Request #11535 - Created May 30, 2013 and submitted

Mengwei Ding
SQOOP-973
Reviewers
Sqoop
abe, hshreedharan, jarcec
sqoop-sqoop2
commit 31a39620c4f102f0eb23958a571d220ee5aa721d
Author: Mengwei Ding <mengwei.ding@cloudera.com>
Date:   Wed May 29 18:04:53 2013 -0700

    SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://localhost:12000/sqoop'

:100644 100644 979b892... 2fd4948... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 1c85592... 41fc17a... M	client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java
:100644 100644 5dbcef5... 9f9289e... M	client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
:100644 100644 e328f9a... afc1ced... M	client/src/main/resources/client-resource.properties
:100644 100644 33419b9... cc3c364... M	docs/src/site/sphinx/CommandLineClient.rst

 
client/src/main/java/org/apache/sqoop/client/core/Constants.java
Revision 979b892 New Change
[20] 42 lines
[+20] [+] public class Constants {
43
  public static final String OPT_VALUE = "value";
43
  public static final String OPT_VALUE = "value";
44
  public static final String OPT_VERBOSE = "verbose";
44
  public static final String OPT_VERBOSE = "verbose";
45
  public static final String OPT_HOST = "host";
45
  public static final String OPT_HOST = "host";
46
  public static final String OPT_PORT = "port";
46
  public static final String OPT_PORT = "port";
47
  public static final String OPT_WEBAPP = "webapp";
47
  public static final String OPT_WEBAPP = "webapp";

    
   
48
  public static final String OPT_URL = "url";
48
  public static final String OPT_SERVER = "server";
49
  public static final String OPT_SERVER = "server";
49
  public static final String OPT_CLIENT = "client";
50
  public static final String OPT_CLIENT = "client";
50
  public static final String OPT_PROTOCOL = "protocol";
51
  public static final String OPT_PROTOCOL = "protocol";
51
  public static final String OPT_SYNCHRONOUS = "synchronous";
52
  public static final String OPT_SYNCHRONOUS = "synchronous";
52
  public static final String OPT_POLL_TIMEOUT = "poll-timeout";
53
  public static final String OPT_POLL_TIMEOUT = "poll-timeout";
[+20] [20] 6 lines
[+20] public class Constants {
59
  public static final char OPT_NAME_CHAR = 'n';
60
  public static final char OPT_NAME_CHAR = 'n';
60
  public static final char OPT_VALUE_CHAR = 'v';
61
  public static final char OPT_VALUE_CHAR = 'v';
61
  public static final char OPT_HOST_CHAR = 'h';
62
  public static final char OPT_HOST_CHAR = 'h';
62
  public static final char OPT_PORT_CHAR = 'p';
63
  public static final char OPT_PORT_CHAR = 'p';
63
  public static final char OPT_WEBAPP_CHAR = 'w';
64
  public static final char OPT_WEBAPP_CHAR = 'w';

    
   
65
  public static final char OPT_URL_CHAR = 'u';
64
  public static final char OPT_SERVER_CHAR = 's';
66
  public static final char OPT_SERVER_CHAR = 's';
65
  public static final char OPT_CLIENT_CHAR = 'c';
67
  public static final char OPT_CLIENT_CHAR = 'c';
66
  public static final char OPT_PROTOCOL_CHAR = 'p';
68
  public static final char OPT_PROTOCOL_CHAR = 'p';
67
  public static final char OPT_SYNCHRONOUS_CHAR = 's';
69
  public static final char OPT_SYNCHRONOUS_CHAR = 's';
68
  public static final char OPT_POLL_TIMEOUT_CHAR = 'p';
70
  public static final char OPT_POLL_TIMEOUT_CHAR = 'p';
[+20] [20] 143 lines
[+20] public class Constants {
212
      "set.host_description";
214
      "set.host_description";
213
  public static final String RES_SET_PORT_DESCRIPTION =
215
  public static final String RES_SET_PORT_DESCRIPTION =
214
      "set.port_description";
216
      "set.port_description";
215
  public static final String RES_WEBAPP_DESCRIPTION =
217
  public static final String RES_WEBAPP_DESCRIPTION =
216
      "set.webapp_description";
218
      "set.webapp_description";

    
   
219
  public static final String RES_URL_DESCRIPTION =

    
   
220
      "set.url_description";
217
  public static final String RES_SET_SERVER_USAGE =
221
  public static final String RES_SET_SERVER_USAGE =
218
      "set.server_usage";
222
      "set.server_usage";
219
  public static final String RES_SET_SERVER_SUCCESSFUL =
223
  public static final String RES_SET_SERVER_SUCCESSFUL =
220
      "set.server_successful";
224
      "set.server_successful";
221

    
   
225

   
[+20] [20] 169 lines
client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java
Revision 1c85592 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
Revision 5dbcef5 New Change
 
client/src/main/resources/client-resource.properties
Revision e328f9a New Change
 
docs/src/site/sphinx/CommandLineClient.rst
Revision 33419b9 New Change
 
  1. client/src/main/java/org/apache/sqoop/client/core/Constants.java: Loading...
  2. client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java: Loading...
  3. client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java: Loading...
  4. client/src/main/resources/client-resource.properties: Loading...
  5. docs/src/site/sphinx/CommandLineClient.rst: Loading...