Review Board 1.7.22


Fix for Sqoop-976: Incremental import with text column as criteria should fail early

Review Request #11524 - Created May 29, 2013 and submitted

Raghav Gautam
SQOOP-976
Reviewers
Sqoop
sqoop-trunk
Incremental import with text column as criteria should fail fast. The patch does this.
I have added new test for this and all the tests pass.
src/docs/user/import.txt
Revision ee10b1c New Change
[20] 309 lines
[+20]
310
[grid="all"]
310
[grid="all"]
311
`-----------------------------`--------------------------------------
311
`-----------------------------`--------------------------------------
312
Argument                      Description
312
Argument                      Description
313
---------------------------------------------------------------------
313
---------------------------------------------------------------------
314
+\--check-column (col)+       Specifies the column to be examined \
314
+\--check-column (col)+       Specifies the column to be examined \
315
                              when determining which rows to import.
315
                              when determining which rows to import.\

    
   
316
                              (the column should not be of type \

    
   
317
                              CHAR/NCHAR/VARCHAR/VARNCHAR/\

    
   
318
                              LONGVARCHAR/LONGNVARCHAR)
316
+\--incremental (mode)+       Specifies how Sqoop determines which \
319
+\--incremental (mode)+       Specifies how Sqoop determines which \
317
                              rows are new. Legal values for +mode+\
320
                              rows are new. Legal values for +mode+\
318
                              include +append+ and +lastmodified+.
321
                              include +append+ and +lastmodified+.
319
+\--last-value (value)+       Specifies the maximum value of the \
322
+\--last-value (value)+       Specifies the maximum value of the \
320
                              check column from the previous import.
323
                              check column from the previous import.
[+20] [20] 410 lines
src/java/org/apache/sqoop/manager/ConnManager.java
Revision a1ac38e New Change
 
src/java/org/apache/sqoop/tool/ImportTool.java
Revision 2627726 New Change
 
src/test/com/cloudera/sqoop/TestIncrementalImport.java
Revision cab77ec New Change
 
  1. src/docs/user/import.txt: Loading...
  2. src/java/org/apache/sqoop/manager/ConnManager.java: Loading...
  3. src/java/org/apache/sqoop/tool/ImportTool.java: Loading...
  4. src/test/com/cloudera/sqoop/TestIncrementalImport.java: Loading...