Review Board 1.7.22


Add Vectorized Substr

Review Request #11106 - Created May 13, 2013 and submitted

Timothy Chen
vectorization
HIVE-4495
Reviewers
hive
hive-git
Add Vectorized Substr

 
Total:
37
Open:
15
Resolved:
21
Dropped:
1
Status:
From:
Description From Last Updated Status
you need to test for some data with multi-byte characters. There is an example of that someplace else in the ... Eric Hanson May 14, 2013, 12:20 a.m. Open
need to try to test the case where data start position is not 0 Eric Hanson May 14, 2013, 12:20 a.m. Open
need to verify the other rows besides 0 are always set to not null. The isNull entries for them could ... Eric Hanson May 14, 2013, 12:20 a.m. Open
Need to have a string with multi-byte characters (or else a separate test of your helper functions using multi-byte characters). ... Eric Hanson May 15, 2013, 6:33 p.m. Open
All strings are starting at 0, so you won't test your helper functions for the case of a string starting ... Eric Hanson May 15, 2013, 6:33 p.m. Open
setting isNull[0] to any value (true or false) is not necessary here because you set noNulls to true. Eric Hanson May 21, 2013, 10:55 p.m. Open
You should only copy n values (the current batch size), not inV.isNull.length. If n<<the default batch size then this code ... Eric Hanson May 21, 2013, 10:55 p.m. Open
this line is not needed because you set outV.noNulls to true Eric Hanson May 21, 2013, 10:55 p.m. Open
you should only do this if !noNulls. Move inside if statement. Also, only copy n values (batch.size). Not the full ... Eric Hanson May 21, 2013, 10:55 p.m. Open
please add some comments to this function to say what the major sections are doing/testing Eric Hanson May 21, 2013, 10:55 p.m. Open
explain why this assertion is correct Eric Hanson May 21, 2013, 10:55 p.m. Open
explain assertion Eric Hanson May 21, 2013, 10:55 p.m. Open
please add some comments to this function Eric Hanson May 21, 2013, 10:55 p.m. Open
explain assertion Eric Hanson May 21, 2013, 10:55 p.m. Open
explain Eric Hanson May 21, 2013, 10:55 p.m. Open
Review request changed
Updated (July 25, 2013, 3:51 a.m.)
  • changed from pending to submitted