Review Board 1.7.22


HIVE-4547: A complex create view statement fails with new Antlr 3.4

Review Request #11084 - Created May 13, 2013 and updated

Prasad Mujumdar
trunk
HIVE-4547
Reviewers
hive
ashutoshc
hive-git
The parser has a translation map where its possible to replace all the text with the appropriate escaped version in case of a view creation. This holds all individual translations and where they apply in the view definition.
The newer antlr version seems to be more restrictive and throws assertion if there's an overlaps in these escape positions. The original patch for antlr upgrade added a check to take care of some of the simpler overlap cases found by unit tests. There are few more scenarios like the one in the customer case which are not covered.
The patch includes Traverse the list of translation in a loop and look for all the possible overlaps.
Ran full test suite. 
Added new test.
Ship it!
Posted (June 3, 2013, 5:50 p.m.)
LGTM. +1 (non-binding).