Review Board 1.7.22


Review request for SQOOP-1033 "CombineFileInputFormat does not work with paths not on default FS like ASV"

Review Request #10988 - Created May 8, 2013 and updated

Shuaishuai Nie
trunk
SQOOP-1033
Reviewers
Sqoop
sqoop-trunk
CombineFileInputFormat does not work with ASV. This appeared as an issue in Sqoop which failed to export files in ASV. CombineFileInputFormat strips out the scheme and authority components of the path, after which point the path is assumed to be on the default file system.
 Sqoop has it own copy of CombineFileInputFormat, but updated the ones in core as well for consistency.

There are currently already solved Jiras for the same issue:
https://issues.apache.org/jira/browse/MAPREDUCE-2704
https://issues.apache.org/jira/browse/MAPREDUCE-1806
Tested in ASV manually
Total:
2
Open:
1
Resolved:
1
Dropped:
0
Status:
From:
Review request changed
Updated (May 9, 2013, 10:16 p.m.)
Remove extra spaces in the patch
Ship it!
Posted (May 10, 2013, 4:49 a.m.)
LGTM.  Thanks for the patch Shuaishuai Nie
  1. Thanks Venkat!
Ship it!
Posted (May 20, 2013, 2:27 p.m.)
Ship It!