Review Board 1.7.22


SQOOP-927 Sqoop2: Integration: Mapreduce specific tests should be running on MiniCluster

Review Request #10964 - Created May 6, 2013 and submitted

Abraham Elmahrek
SQOOP-927
Reviewers
Sqoop
jarcec
sqoop-sqoop2
commit 2cc666f2aa1ac679a58099819a6985a19dfb5de9
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Tue Jul 2 11:53:57 2013 -0700

    SQOOP-927 Sqoop2: Integration: Mapreduce specific tests should be running on MiniCluster
    
    Minicluster test output set to <temp dir>/minicluster.
    
    Set yarn.application.classpath to get over classpath errors.
    Set to use fair scheduler.

:100644 100644 513b6d0... 524117e... M  pom.xml
:100644 100644 c175272... d8f2b8d... M  test/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.java
:000000 100644 0000000... 44465b4... A  test/src/main/java/org/apache/sqoop/test/hadoop/HadoopLocalRunner.java
:000000 100644 0000000... b06dcab... A  test/src/main/java/org/apache/sqoop/test/hadoop/HadoopMiniClusterRunner.java
:000000 100644 0000000... 2516ff1... A  test/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunner.java
:000000 100644 0000000... 020fa3f... A  test/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunnerFactory.java
:100644 100644 d10b942... 5ec4fa4... M  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java
:100644 100644 efdfed4... 7e2558f... M  test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java
:100644 100644 95dd177... 59c5f15... M  test/src/main/java/org/apache/sqoop/test/utils/HdfsUtils.java
mvn clean integration-test -DfailIfNoTests=false -X -Phadoop100 -Dhadoop.profile=100 -Dsurefire.useFile=false -Dmaven.test.redirectTestOutputToFile=false
mvn clean integration-test -DfailIfNoTests=false -X -Dsurefire.useFile=false -Dmaven.test.redirectTestOutputToFile=false
mvn clean integration-test -DfailIfNoTests=false -X -Phadoop100 -Dhadoop.profile=100 -Dsurefire.useFile=false -Dmaven.test.redirectTestOutputToFile=false -Dsqoop.hadoop.runner.class=org.apache.sqoop.test.hadoop.HadoopLocalRunner
mvn clean integration-test -DfailIfNoTests=false -X -Dsurefire.useFile=false -Dmaven.test.redirectTestOutputToFile=false -Dsqoop.hadoop.runner.class=org.apache.sqoop.test.hadoop.HadoopLocalRunner
Total:
50
Open:
3
Resolved:
44
Dropped:
3
Status:
From:
Description From Last Updated Status
I think that the main temporary path should be owned by this class because we are storing there a lot ... Jarek Cecho July 9, 2013, 6:14 p.m. Open
Nit: Wouldn't make sense to log "Stopping" and then start stopping the service? Jarek Cecho Aug. 23, 2013, 11:24 p.m. Open
Nit: Wouldn't make sense to log "Stopping" and then start stopping the service? Jarek Cecho Aug. 23, 2013, 11:24 p.m. Open
Review request changed
Updated (Oct. 23, 2013, 12:15 a.m.)
  • changed from pending to submitted