Review Board 1.7.22


HIVE-4459 Script hcat is overriding HIVE_CONF_DIR variable

Review Request #10878 - Created April 30, 2013 and submitted

Jarek Cecho
HIVE-4459
Reviewers
hive
hive
I've altered the hard coded value so that it will be picked up only in case that the HIVE_CONF_DIR is not already set.
I've tested the altered script with and without explicitly setting HIVE_CONF_DIR.

Diff revision 1 (Latest)

  1. /trunk/hcatalog/bin/hcat: Loading...
/trunk/hcatalog/bin/hcat
Revision 1477863 New Change
[20] 88 lines
[+20]
89
if [ ! -d "$HIVE_LIB_DIR" ]; then
89
if [ ! -d "$HIVE_LIB_DIR" ]; then
90
  echo "Cannot find lib dir within HIVE_HOME : $HIVE_LIB_DIR";
90
  echo "Cannot find lib dir within HIVE_HOME : $HIVE_LIB_DIR";
91
  exit 4;
91
  exit 4;
92
fi
92
fi
93

    
   
93

   
94
HIVE_CONF_DIR=${HIVE_HOME}/conf
94
HIVE_CONF_DIR=${HIVE_CONF_DIR:-$HIVE_HOME/conf}
95
if [ ! -d "$HIVE_CONF_DIR" ]; then
95
if [ ! -d "$HIVE_CONF_DIR" ]; then
96
  echo "Cannot find conf dir within HIVE_HOME : $HIVE_CONF_DIR";
96
  echo "Cannot find conf dir within HIVE_HOME : $HIVE_CONF_DIR";
97
  exit 4;
97
  exit 4;
98
fi
98
fi
99

    
   
99

   
[+20] [20] 50 lines
  1. /trunk/hcatalog/bin/hcat: Loading...