Review Board 1.7.22


FLUME-2015 ElasticSearchSink: need access to IndexRequestBuilder instance during flume event processing

Review Request #10835 - Created April 29, 2013 and updated

Tim Bacon
flume-1.4
FLUME-2015
Reviewers
Flume
iekpo
flume-git
This change adds an ElasticSearchIndexRequestBuilderFactory interface to allow users of an ElasticSearchSink to have greater control over the actual indexing of events that arrive at the sink. It is intended to meet the needs of:
- my own non-Kibana/non-logging-event use case
- the specific "allow for indexing an id-field" needs of FLUME-1972
- the (UTC) determination of the index to write to per FLUME-1782

This patch is backwards-compatible and imposes no changes on existing users of the sink.
Unit tests added and run.
Patch applied and run successfully in my own flume test environment.
Total:
1
Open:
0
Resolved:
0
Dropped:
1
Status:
From:
Review request changed
Updated (May 10, 2013, 10:08 a.m.)
Changes from prior diff: ElasticSearchIndexRequestBuilderFactory interface should extend Configurable / ConfigurableComponent
Ship it!
Posted (May 10, 2013, 8:19 p.m.)
+1 looks good!

I did not test this myself (although the unit tests pass) but I know you and Edward did so that's good enough for me. :)