Review Board 1.7.22


SQOOP-1008 Test TestClassWriter.testNoClassGeneration is failing on JDK7

Review Request #10731 - Created April 23, 2013 and submitted

Jarek Cecho
SQOOP-1008
Reviewers
Sqoop
sqoop-trunk
I've changed expectation of IOException to just an Exception.
The test seems to be passing on both JDK6 and JDK7.

Diff revision 1 (Latest)

  1. src/test/com/cloudera/sqoop/orm/TestClassWriter.java: Loading...
src/test/com/cloudera/sqoop/orm/TestClassWriter.java
Revision 6158fb438babc967f28702301619807e9e0a9c3c New Change
[20] 510 lines
[+20] [+] private void runFailedGenerationTest(String [] argv,
511

    
   
511

   
512
    try {
512
    try {
513
      writer.generate();
513
      writer.generate();
514
      compileMgr.compile();
514
      compileMgr.compile();
515
      fail("ORM class file generation succeeded when it was expected to fail");
515
      fail("ORM class file generation succeeded when it was expected to fail");
516
    } catch (IOException ioe) {
516
    } catch (Exception ioe) {
517
      LOG.error("Got IOException from ORM generation as expected : "
517
      LOG.error("Got Exception from ORM generation as expected : "
518
        + ioe.toString());
518
        + ioe.toString());
519
    }
519
    }
520
  }
520
  }
521
  /**
521
  /**
522
   * A dummy manager that declares that it ORM is self managed.
522
   * A dummy manager that declares that it ORM is self managed.
[+20] [20] 20 lines
  1. src/test/com/cloudera/sqoop/orm/TestClassWriter.java: Loading...