Review Board 1.7.22


Sqoop2: sqoop.sh execution error

Review Request #10689 - Created April 21, 2013 and updated

Vasanth kumar RJ
SQOOP-1003
Reviewers
Sqoop
sqoop-sqoop2
Problem while starting and stopping sqoop server.
Patch supports softlink for both server and client command. 
Done
Total:
2
Open:
0
Resolved:
2
Dropped:
0
Status:
From:
Review request changed
Updated (May 1, 2013, 7:02 p.m.)
Implemented Jarek's comments
Posted (May 2, 2013, 12:33 a.m.)
Hi Vasanth,
thank you for your time and effort with this!
dist/src/main/bin/sqoop.sh (Diff revision 2)
 
 
 
 
Nit: It seems that the cd on line 50 is not necessary as we've already changed the working directory on line 48 if I'm not mistaken.
  1. Hi Jarcec,
    At line 48, just getting value and not actually changing directory. I tried 'pwd' command at before and after the 48th line, prints same path. Only at line 50, actually changing directory path. 
    Even I removed line 50 as per your suggestion, getting execution error at line 93.
    
    Thanks,
    Vasanth kumar
  2. Thank you for verifying Vasanth!
Jarcec
Ship it!
Posted (May 3, 2013, 5:25 a.m.)
Ship It!