Review Board 1.7.22


FLUME-1889 - Add HBASE and ASYNC_HBASE enum types to SinkType

Review Request #10445 - Created April 13, 2013 and updated

Israel Ekpo
flume-1.4
FLUME-1889, FLUME-1994
Reviewers
Flume
flume-git
Modified SyncType and SinkConfiguration to support this improvement.
The unit tests added simulate how these sinks are loaded.

flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java
Revision c6c99d5 New Change
[20] 115 lines
[+20] [+] public String toString(int indentCount){
116
    /**
116
    /**
117
     * Thrift sink
117
     * Thrift sink
118
     *
118
     *
119
     * @see ThriftSink
119
     * @see ThriftSink
120
     */
120
     */
121
    THRIFT("org.apache.flume.conf.sink.ThriftSinkConfiguration");
121
    THRIFT("org.apache.flume.conf.sink.ThriftSinkConfiguration"),

    
   
122

   

    
   
123
    /**

    
   
124
     * ElasticSearch Sink

    
   
125
     *

    
   
126
     * @see org.apache.flume.sink.elasticsearch.ElasticSearchSink

    
   
127
     */

    
   
128
    ELASTICSEARCH("org.apache.flume.sink.elasticsearch.ElasticSearchSinkConfiguration"),

    
   
129

   

    
   
130
    /**

    
   
131
     * HBase Sink

    
   
132
     *

    
   
133
     * @see org.apache.flume.sink.hbase.HBaseSink

    
   
134
     */

    
   
135
    HBASE("org.apache.flume.sink.hbase.HBaseSinkConfiguration"),

    
   
136

   

    
   
137
    /**

    
   
138
     * AsyncHBase Sink

    
   
139
     *

    
   
140
     * @see org.apache.flume.sink.hbase.AsyncHBaseSink

    
   
141
     */

    
   
142
    ASYNCHBASE("org.apache.flume.sink.hbase.HBaseSinkConfiguration");
122

    
   
143

   
123
    private final String sinkConfigurationName;
144
    private final String sinkConfigurationName;
124

    
   
145

   
125
    private SinkConfigurationType(String type) {
146
    private SinkConfigurationType(String type) {
126
      this.sinkConfigurationName = type;
147
      this.sinkConfigurationName = type;
[+20] [20] 37 lines
flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java
Revision 7e0288e New Change
 
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSinkCreation.java
New File
 
flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestHBaseSinkCreation.java
New File
 
  1. flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java: Loading...
  2. flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java: Loading...
  3. flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSinkCreation.java: Loading...
  4. flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestHBaseSinkCreation.java: Loading...