Review Board 1.7.22


SQOOP-895 Sqoop2: Do not serialize framework and connector configurations into mapreduce configuration object

Review Request #10332 - Created April 8, 2013 and submitted

Jarek Cecho
SQOOP-895
Reviewers
Sqoop
sqoop-sqoop2
I've used mapreduce credentials cache to store the configuration objects similarly as we did in SQOOP-914.
Unit and integration tests seems to be passing. I've also verified the changes on real cluster.
execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java
Revision e16a2c4 New Change
[20] 14 lines
[+20]
15
 * See the License for the specific language governing permissions and
15
 * See the License for the specific language governing permissions and
16
 * limitations under the License.
16
 * limitations under the License.
17
 */
17
 */
18
package org.apache.sqoop.job;
18
package org.apache.sqoop.job;
19

    
   
19

   

    
   
20
import org.apache.hadoop.io.Text;
20
import org.apache.sqoop.core.ConfigurationConstants;
21
import org.apache.sqoop.core.ConfigurationConstants;
21

    
   
22

   
22
public final class JobConstants extends Constants {
23
public final class JobConstants extends Constants {
23
  /**
24
  /**
24
   * All job related configuration is prefixed with this:
25
   * All job related configuration is prefixed with this:
[+20] [20] 40 lines
[+20]
65
    PREFIX_JOB_CONFIG + "config.class.framework.job";
66
    PREFIX_JOB_CONFIG + "config.class.framework.job";
66

    
   
67

   
67
  public static final String JOB_CONFIG_CONNECTOR_CONNECTION =
68
  public static final String JOB_CONFIG_CONNECTOR_CONNECTION =
68
    PREFIX_JOB_CONFIG + "config.connector.connection";
69
    PREFIX_JOB_CONFIG + "config.connector.connection";
69

    
   
70

   

    
   
71
  public static final Text JOB_CONFIG_CONNECTOR_CONNECTION_KEY =

    
   
72
    new Text(JOB_CONFIG_CONNECTOR_CONNECTION);

    
   
73

   
70
  public static final String JOB_CONFIG_CONNECTOR_JOB =
74
  public static final String JOB_CONFIG_CONNECTOR_JOB =
71
    PREFIX_JOB_CONFIG + "config.connector.job";
75
    PREFIX_JOB_CONFIG + "config.connector.job";
72

    
   
76

   

    
   
77
  public static final Text JOB_CONFIG_CONNECTOR_JOB_KEY =

    
   
78
    new Text(JOB_CONFIG_CONNECTOR_JOB);

    
   
79

   
73
  public static final String JOB_CONFIG_FRAMEWORK_CONNECTION =
80
  public static final String JOB_CONFIG_FRAMEWORK_CONNECTION =
74
    PREFIX_JOB_CONFIG + "config.framework.connection";
81
    PREFIX_JOB_CONFIG + "config.framework.connection";
75

    
   
82

   

    
   
83
  public static final Text JOB_CONFIG_FRAMEWORK_CONNECTION_KEY =

    
   
84
    new Text(JOB_CONFIG_FRAMEWORK_CONNECTION);

    
   
85

   
76
  public static final String JOB_CONFIG_FRAMEWORK_JOB =
86
  public static final String JOB_CONFIG_FRAMEWORK_JOB =
77
    PREFIX_JOB_CONFIG + "config.framework.job";
87
    PREFIX_JOB_CONFIG + "config.framework.job";
78

    
   
88

   

    
   
89
  public static final Text JOB_CONFIG_FRAMEWORK_JOB_KEY =

    
   
90
    new Text(JOB_CONFIG_FRAMEWORK_JOB);

    
   
91

   
79
  public static final String PREFIX_CONNECTOR_CONTEXT =
92
  public static final String PREFIX_CONNECTOR_CONTEXT =
80
    PREFIX_JOB_CONFIG + "connector.context.";
93
    PREFIX_JOB_CONFIG + "connector.context.";
81

    
   
94

   
82
  // Hadoop specific constants
95
  // Hadoop specific constants
83
  // We're using constants from Hadoop 1. Hadoop 2 has different names, but
96
  // We're using constants from Hadoop 1. Hadoop 2 has different names, but
[+20] [20] 15 lines
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java
Revision 4aa2128 New Change
 
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java
Revision 77f30ea New Change
 
  1. execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java: Loading...
  2. execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java: Loading...
  3. submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java: Loading...