Review Board 1.7.22


FLUME-1741 ElasticSearch tests leave directory data/elasticsearch/nodes/ lying around

Review Request #10251 - Created April 3, 2013 and updated

Jeff jlord
FLUME-1741
Reviewers
Flume
flume-git
Modify elastic search nodebuilder to clean up test directories.

 
Review request changed
Updated (April 3, 2013, 5:18 a.m.)
  • changed from ElasticSearch tests leave directory data/elasticsearch/nodes/ lying around to FLUME-1741 ElasticSearch tests leave directory data/elasticsearch/nodes/ lying around
Posted (April 3, 2013, 9:47 p.m.)
Hi Jeff,
Sorry for my limited knowledge of ES, it looks to me that when we set path.data = "target" I guess that means ES will store its data into the "target" directory under the flume-ng-elasticsearch-sink directory. Since target gets cleaned up automatically I think that's a good solution but I wonder if we shouldn't give one more level down so that ES doesn't accidentally stomp on some Maven build directories or something. i.e. set it to "target/es-test" or something, if that path will be automatically created.

Also, please indicate what level of testing was done, ideally "unit tests pass" and "manually verified that directories are being cleaned up".

Thanks!
Mike