Review Board 1.7.22


Sqoop2: HdfsExportPartitioner is not always respecting maximal number of partitions

Review Request #10143 - Created March 26, 2013 and updated

Vasanth kumar RJ
sqoop-844
Reviewers
Sqoop
sqoop-sqoop2
HdfsExportPartitioner is not always respecting maximal number of partitions.
Modified partition logic.
Before using this patch, for simulating the failure in base code.
In TestHdfsExtract.java, change NUMBER_OF_ROWS_PER_FILE = 1. Then try running particular test case given in this patch. Where returning partitions size is greater than required.

Fix will create partitions less than or equal to required. Fixed.
Total:
1
Open:
1
Resolved:
0
Dropped:
0
Status:
From:
Review request changed
Updated (April 2, 2013, 11:54 a.m.)
  • Done

    Before using this patch, for simulating the failure in base code.
    In TestHdfsExtract.java, change NUMBER_OF_ROWS_PER_FILE = 1. Then try running particular test case given in this patch. Where returning partitions size is greater than required.
    
    Fix will create partitions less than or equal to required. Fixed.
Implemented Jarek's suggestion and added test case.

Ship it!
Posted (April 13, 2013, 6:40 p.m.)
Ship It!