Review Board 1.7.22


SQOOP-663 Introduce connector SDK

Review Request #10106 - Created March 24, 2013 and updated

Jarek Cecho
SQOOP-663
Reviewers
Sqoop
sqoop-sqoop2
I've created first cut of connector SDK and I would like to get other's feedback. I've created new maven module and put all forms and appropriate validations inside rather than having them inside the Generic JDBC Connector. I'm expecting that they will be heavily reused between various connectors.
Integration and unit tests seems to be passing.

Diff revision 2 (Latest)

1 2
1 2

  1. pom.xml: Loading...
  2. connector/pom.xml: Loading...
  3. connector/connector-generic-jdbc/pom.xml: Loading...
  4. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java: Loading...
  5. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java: Loading...
  6. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java: Loading...
  7. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java: Loading...
  8. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java: Loading...
  9. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ConnectionConfiguration.java: Loading...
  10. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ConnectionForm.java: Loading...
  11. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportJobConfiguration.java: Loading...
  12. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportTableForm.java: Loading...
  13. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportJobConfiguration.java: Loading...
  14. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportTableForm.java: Loading...
  15. connector/connector-sdk/pom.xml: Loading...
  16. connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/constant/SdkConstants.java: Loading...
  17. connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/form/ConnectionForm.java: Loading...
  18. connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/form/ExportTableForm.java: Loading...
  19. connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/form/ImportTableForm.java: Loading...
  20. connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/validation/ValidationUtil.java: Loading...
pom.xml
Revision 25dfba6cbf839f5139dec93c10cf746434847acf New Change
[20] 279 lines
[+20]
280
        <groupId>org.apache.sqoop.connector</groupId>
280
        <groupId>org.apache.sqoop.connector</groupId>
281
        <artifactId>sqoop-connector-generic-jdbc</artifactId>
281
        <artifactId>sqoop-connector-generic-jdbc</artifactId>
282
        <version>${project.version}</version>
282
        <version>${project.version}</version>
283
      </dependency>
283
      </dependency>
284
      <dependency>
284
      <dependency>

    
   
285
        <groupId>org.apache.sqoop</groupId>

    
   
286
        <artifactId>sqoop-connector-sdk</artifactId>

    
   
287
        <version>${project.version}</version>

    
   
288
      </dependency>

    
   
289
      <dependency>
285
        <groupId>org.apache.sqoop.connector</groupId>
290
        <groupId>org.apache.sqoop.connector</groupId>
286
        <artifactId>sqoop-connector-generic-jdbc</artifactId>
291
        <artifactId>sqoop-connector-generic-jdbc</artifactId>
287
        <type>test-jar</type>
292
        <type>test-jar</type>
288
        <version>${project.version}</version>
293
        <version>${project.version}</version>
289
      </dependency>
294
      </dependency>
[+20] [20] 342 lines
connector/pom.xml
Revision 68969a0ab284bc760ff5cc5a371523c8e5683d8f New Change
 
connector/connector-generic-jdbc/pom.xml
Revision 73161f0108d654064b0abfca57ca2d6f100d1049 New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java
Revision 23f19b5fdfe4134eb621d1ecb0fff08379abb7c1 New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java
Revision 40a777499492a3b18f1fee1fd96222c77b8868ce New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java
Revision d54b43021fc6f8554978ec284f52159951de44f9 New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
Revision 3e9789c35e1e56d53d30257801cc8ce6194bbc0c New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
Revision 4e24517f0c1242bdcf105fc4d77c19d2673e4cd6 New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ConnectionConfiguration.java
Revision 6061600b8ce2d302a1ef69279b38f6f06508d0a5 New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ConnectionForm.java
Revision c35449460e63ebbe3f999dc4853ad829db208b82 New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportJobConfiguration.java
Revision f2b2d656b623acebc74eb3899d0a7893c1be1907 New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportTableForm.java
Revision ee4bb6e57d1abcc4a9269d93e6384d9f2c315a1c New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportJobConfiguration.java
Revision f3c1d13c884c8a91d74af62e43fe8547c4961d54 New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportTableForm.java
Revision 3422a8fa28c0a594e4eb454f46fe73f6760d81ba New Change
 
connector/connector-sdk/pom.xml
New File
 
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/constant/SdkConstants.java
New File
 
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/form/ConnectionForm.java
New File
 
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/form/ExportTableForm.java
New File
 
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/form/ImportTableForm.java
New File
 
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/validation/ValidationUtil.java
New File
 
  1. pom.xml: Loading...
  2. connector/pom.xml: Loading...
  3. connector/connector-generic-jdbc/pom.xml: Loading...
  4. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java: Loading...
  5. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java: Loading...
  6. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java: Loading...
  7. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java: Loading...
  8. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java: Loading...
  9. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ConnectionConfiguration.java: Loading...
  10. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ConnectionForm.java: Loading...
  11. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportJobConfiguration.java: Loading...
  12. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportTableForm.java: Loading...
  13. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportJobConfiguration.java: Loading...
  14. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportTableForm.java: Loading...
  15. connector/connector-sdk/pom.xml: Loading...
  16. connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/constant/SdkConstants.java: Loading...
  17. connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/form/ConnectionForm.java: Loading...
  18. connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/form/ExportTableForm.java: Loading...
  19. connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/form/ImportTableForm.java: Loading...
  20. connector/connector-sdk/src/main/java/org/apache/sqoop/connector/sdk/validation/ValidationUtil.java: Loading...