Review Board 1.7.22


Sqoop2: Help option for shell command functions

Review Request #10100 - Created March 24, 2013 and updated

Vasanth kumar RJ
sqoop-965
Reviewers
Sqoop
sqoop-sqoop2
There is no help option for shell command's functions. Introducing the help argument for functions.
Done

Diff revision 2

This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

1 2 3
1 2 3

  1. client/src/main/java/org/apache/sqoop/client/core/Constants.java: Loading...
  2. client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java: Loading...
  3. client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java: Loading...
  4. client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java: Loading...
  5. client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java: Loading...
  6. client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java: Loading...
  7. client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java: Loading...
  8. client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java: Loading...
  9. client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java: Loading...
  10. client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java: Loading...
  11. client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java: Loading...
  12. client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java: Loading...
  13. client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java: Loading...
  14. client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java: Loading...
  15. client/src/main/java/org/apache/sqoop/client/shell/ShowServerFunction.java: Loading...
  16. client/src/main/java/org/apache/sqoop/client/shell/ShowVersionFunction.java: Loading...
  17. client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java: Loading...
  18. client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java: Loading...
  19. client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java: Loading...
  20. client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java: Loading...
  21. client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java: Loading...
  22. client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java: Loading...
  23. client/src/main/resources/client-resource.properties: Loading...
  24. docs/src/site/sphinx/CommandLineClient.rst: Loading...
client/src/main/java/org/apache/sqoop/client/core/Constants.java
Revision cc80df1 New Change
[20] 40 lines
[+20] [+] public class Constants {
41
  public static final String OPT_PORT = "port";
41
  public static final String OPT_PORT = "port";
42
  public static final String OPT_WEBAPP = "webapp";
42
  public static final String OPT_WEBAPP = "webapp";
43
  public static final String OPT_SERVER = "server";
43
  public static final String OPT_SERVER = "server";
44
  public static final String OPT_CLIENT = "client";
44
  public static final String OPT_CLIENT = "client";
45
  public static final String OPT_PROTOCOL = "protocol";
45
  public static final String OPT_PROTOCOL = "protocol";

    
   
46
  public static final String OPT_HELP = "help";
46

    
   
47

   
47
  public static final char OPT_XID_CHAR = 'x';
48
  public static final char OPT_XID_CHAR = 'x';
48
  public static final char OPT_ALL_CHAR = 'a';
49
  public static final char OPT_ALL_CHAR = 'a';
49
  public static final char OPT_JID_CHAR = 'j';
50
  public static final char OPT_JID_CHAR = 'j';
50
  public static final char OPT_CID_CHAR = 'c';
51
  public static final char OPT_CID_CHAR = 'c';
51
  public static final char OPT_TYPE_CHAR = 't';
52
  public static final char OPT_TYPE_CHAR = 't';
52
  public static final char OPT_NAME_CHAR = 'n';
53
  public static final char OPT_NAME_CHAR = 'n';
53
  public static final char OPT_VALUE_CHAR = 'v';
54
  public static final char OPT_VALUE_CHAR = 'v';
54
  public static final char OPT_HOST_CHAR = 'h';
55
  public static final char OPT_HOST_CHAR = 'i';
55
  public static final char OPT_PORT_CHAR = 'p';
56
  public static final char OPT_PORT_CHAR = 'p';
56
  public static final char OPT_WEBAPP_CHAR = 'w';
57
  public static final char OPT_WEBAPP_CHAR = 'w';
57
  public static final char OPT_SERVER_CHAR = 's';
58
  public static final char OPT_SERVER_CHAR = 's';
58
  public static final char OPT_CLIENT_CHAR = 'c';
59
  public static final char OPT_CLIENT_CHAR = 'c';
59
  public static final char OPT_PROTOCOL_CHAR = 'p';
60
  public static final char OPT_PROTOCOL_CHAR = 'p';

    
   
61
  public static final char OPT_HELP_CHAR = 'h';
60

    
   
62

   
61
  // Resource keys for various commands, command options,
63
  // Resource keys for various commands, command options,
62
  // functions and descriptions
64
  // functions and descriptions
63
  public static final String CMD_CLONE = "clone";
65
  public static final String CMD_CLONE = "clone";
64
  public static final String CMD_CLONE_SC = "\\cl";
66
  public static final String CMD_CLONE_SC = "\\cl";
[+20] [20] 87 lines
[+20] public class Constants {
152
      "clone.job.successful";
154
      "clone.job.successful";
153
  public static final String RES_CLONE_CLONING_CONN =
155
  public static final String RES_CLONE_CLONING_CONN =
154
      "clone.cloning_conn";
156
      "clone.cloning_conn";
155
  public static final String RES_CLONE_CLONING_JOB =
157
  public static final String RES_CLONE_CLONING_JOB =
156
      "clone.cloning_job";
158
      "clone.cloning_job";

    
   
159
  public static final String RES_CLONE_CONN_USAGE =

    
   
160
      "clone.conn_usage";

    
   
161
  public static final String RES_CLONE_JOB_USAGE =

    
   
162
      "clone.job_usage";
157

    
   
163

   
158
  public static final String RES_CREATE_USAGE =
164
  public static final String RES_CREATE_USAGE =
159
      "create.usage";
165
      "create.usage";
160
  public static final String RES_CREATE_CONN_SUCCESSFUL =
166
  public static final String RES_CREATE_CONN_SUCCESSFUL =
161
      "create.conn_successful";
167
      "create.conn_successful";
162
  public static final String RES_CREATE_JOB_SUCCESSFUL =
168
  public static final String RES_CREATE_JOB_SUCCESSFUL =
163
      "create.job_successful";
169
      "create.job_successful";
164
  public static final String RES_CREATE_CREATING_CONN =
170
  public static final String RES_CREATE_CREATING_CONN =
165
      "create.creating_conn";
171
      "create.creating_conn";
166
  public static final String RES_CREATE_CREATING_JOB =
172
  public static final String RES_CREATE_CREATING_JOB =
167
      "create.creating_job";
173
      "create.creating_job";

    
   
174
  public static final String RES_CREATE_CONN_USAGE =

    
   
175
      "create.conn_usage";

    
   
176
  public static final String RES_CREATE_JOB_USAGE =

    
   
177
      "create.job_usage";
168

    
   
178

   
169
  public static final String RES_DELETE_USAGE =
179
  public static final String RES_DELETE_USAGE =
170
      "delete.usage";
180
      "delete.usage";

    
   
181
  public static final String RES_DELETE_CONN_USAGE =

    
   
182
      "delete.conn_usage";

    
   
183
  public static final String RES_DELETE_JOB_USAGE =

    
   
184
      "delete.job_usage";
171

    
   
185

   
172
  public static final String RES_HELP_USAGE =
186
  public static final String RES_HELP_USAGE =
173
      "help.usage";
187
      "help.usage";
174
  public static final String RES_HELP_DESCRIPTION =
188
  public static final String RES_HELP_DESCRIPTION =
175
      "help.description";
189
      "help.description";
[+20] [20] 11 lines
[+20] public class Constants {
187
      "help.specific_cmd_info";
201
      "help.specific_cmd_info";
188

    
   
202

   
189
  public static final String RES_UNRECOGNIZED_CMD =
203
  public static final String RES_UNRECOGNIZED_CMD =
190
      "unrecognized.cmd";
204
      "unrecognized.cmd";
191

    
   
205

   

    
   
206
  public static final String RES_FUNCTION_HELP_DESCRIPTION =

    
   
207
      "function.help.description";

    
   
208

   
192
  public static final String RES_SET_USAGE =
209
  public static final String RES_SET_USAGE =
193
      "set.usage";
210
      "set.usage";
194
  public static final String RES_SET_PROMPT_OPT_NAME =
211
  public static final String RES_SET_PROMPT_OPT_NAME =
195
      "set.prompt_opt_name";
212
      "set.prompt_opt_name";
196
  public static final String RES_SET_PROMPT_OPT_VALUE =
213
  public static final String RES_SET_PROMPT_OPT_VALUE =
[+20] [20] 10 lines
[+20] public class Constants {
207
      "set.webapp_description";
224
      "set.webapp_description";
208
  public static final String RES_SET_SERVER_USAGE =
225
  public static final String RES_SET_SERVER_USAGE =
209
      "set.server_usage";
226
      "set.server_usage";
210
  public static final String RES_SET_SERVER_SUCCESSFUL =
227
  public static final String RES_SET_SERVER_SUCCESSFUL =
211
      "set.server_successful";
228
      "set.server_successful";

    
   
229
  public static final String RES_SET_OPTION_USAGE =

    
   
230
      "set.option_usage";
212

    
   
231

   
213
  public static final String RES_SHOW_USAGE =
232
  public static final String RES_SHOW_USAGE =
214
      "show.usage";
233
      "show.usage";
215
  public static final String RES_SHOW_PROMPT_DISPLAY_ALL_CONNS =
234
  public static final String RES_SHOW_PROMPT_DISPLAY_ALL_CONNS =
216
      "show.prompt_display_all_conns";
235
      "show.prompt_display_all_conns";
[+20] [20] 62 lines
[+20] public class Constants {
279
      "show.version_usage";
298
      "show.version_usage";
280
  public static final String RES_SHOW_PROMPT_VERSION_CLIENT_SERVER =
299
  public static final String RES_SHOW_PROMPT_VERSION_CLIENT_SERVER =
281
      "show.prompt_version_client_server";
300
      "show.prompt_version_client_server";
282
  public static final String RES_SHOW_PROMPT_VERSION_PROTOCOL =
301
  public static final String RES_SHOW_PROMPT_VERSION_PROTOCOL =
283
      "show.prompt_version_protocol";
302
      "show.prompt_version_protocol";

    
   
303
  public static final String RES_SHOW_OPTION_USAGE =

    
   
304
      "show.option_usage";
284

    
   
305

   
285
  public static final String RES_SQOOP_SHELL_BANNER =
306
  public static final String RES_SQOOP_SHELL_BANNER =
286
      "sqoop.shell_banner";
307
      "sqoop.shell_banner";
287
  public static final String RES_SQOOP_PROMPT_SHELL_LOADRC =
308
  public static final String RES_SQOOP_PROMPT_SHELL_LOADRC =
288
      "sqoop.prompt_shell_loadrc";
309
      "sqoop.prompt_shell_loadrc";
289
  public static final String RES_SQOOP_PROMPT_SHELL_LOADEDRC =
310
  public static final String RES_SQOOP_PROMPT_SHELL_LOADEDRC =
290
      "sqoop.prompt_shell_loadedrc";
311
      "sqoop.prompt_shell_loadedrc";
291

    
   
312

   
292
  public static final String RES_SUBMISSION_USAGE =
313
  public static final String RES_SUBMISSION_USAGE =
293
      "submission.usage";
314
      "submission.usage";

    
   
315
  public static final String RES_SUBMISSION_START_USAGE =

    
   
316
      "submission.start_usage";

    
   
317
  public static final String RES_SUBMISSION_STOP_USAGE =

    
   
318
      "submission.stop_usage";

    
   
319
  public static final String RES_SUBMISSION_STATUS_USAGE =

    
   
320
      "submission.status_usage";
294

    
   
321

   
295
  public static final String RES_UPDATE_USAGE =
322
  public static final String RES_UPDATE_USAGE =
296
      "update.usage";
323
      "update.usage";
297
  public static final String RES_UPDATE_UPDATING_CONN =
324
  public static final String RES_UPDATE_UPDATING_CONN =
298
      "update.conn";
325
      "update.conn";
299
  public static final String RES_UPDATE_CONN_SUCCESSFUL =
326
  public static final String RES_UPDATE_CONN_SUCCESSFUL =
300
      "update.conn_successful";
327
      "update.conn_successful";
301
  public static final String RES_UPDATE_UPDATING_JOB =
328
  public static final String RES_UPDATE_UPDATING_JOB =
302
      "update.job";
329
      "update.job";
303
  public static final String RES_UPDATE_JOB_SUCCESSFUL =
330
  public static final String RES_UPDATE_JOB_SUCCESSFUL =
304
      "update.job_successful";
331
      "update.job_successful";

    
   
332
  public static final String RES_UPDATE_CONNECTION_USAGE =

    
   
333
      "update.conn_usage";

    
   
334
  public static final String RES_UPDATE_JOB_USAGE =

    
   
335
      "update.job_usage";
305

    
   
336

   
306
  public static final String RES_TABLE_HEADER_ID =
337
  public static final String RES_TABLE_HEADER_ID =
307
      "table.header.id";
338
      "table.header.id";
308
  public static final String RES_TABLE_HEADER_NAME =
339
  public static final String RES_TABLE_HEADER_NAME =
309
      "table.header.name";
340
      "table.header.name";
[+20] [20] 44 lines
client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java
Revision 0538901 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java
Revision 6f62813 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java
Revision 5bf9aaa New Change
 
client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java
Revision f5155d5 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java
Revision 18d3a70 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java
Revision 736be20 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
Revision 9414b7d New Change
 
client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java
Revision 1c85592 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
Revision 4fe20c1 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java
Revision 19a8123 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java
Revision d37b73a New Change
 
client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
Revision 5505d51 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
Revision 890ede1 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/ShowServerFunction.java
Revision 110f67e New Change
 
client/src/main/java/org/apache/sqoop/client/shell/ShowVersionFunction.java
Revision 1038116 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
Revision bf26761 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java
Revision cefe0a2 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
Revision 48db8ab New Change
 
client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java
Revision 8291a54 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java
Revision 95ada63 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java
Revision 3f0ac7d New Change
 
client/src/main/resources/client-resource.properties
Revision 734333e New Change
 
docs/src/site/sphinx/CommandLineClient.rst
Revision 1b9676f New Change
 
  1. client/src/main/java/org/apache/sqoop/client/core/Constants.java: Loading...
  2. client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java: Loading...
  3. client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java: Loading...
  4. client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java: Loading...
  5. client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java: Loading...
  6. client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java: Loading...
  7. client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java: Loading...
  8. client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java: Loading...
  9. client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java: Loading...
  10. client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java: Loading...
  11. client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java: Loading...
  12. client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java: Loading...
  13. client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java: Loading...
  14. client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java: Loading...
  15. client/src/main/java/org/apache/sqoop/client/shell/ShowServerFunction.java: Loading...
  16. client/src/main/java/org/apache/sqoop/client/shell/ShowVersionFunction.java: Loading...
  17. client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java: Loading...
  18. client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java: Loading...
  19. client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java: Loading...
  20. client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java: Loading...
  21. client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java: Loading...
  22. client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java: Loading...
  23. client/src/main/resources/client-resource.properties: Loading...
  24. docs/src/site/sphinx/CommandLineClient.rst: Loading...