Review Board 1.7.22


Request to review patch for SQOOP-954: Create Sqoop runtime scripts to run Sqoop on Windows

Review Request #10055 - Created March 20, 2013 and updated

Ahmed El Baz
trunk
SQOOP-954
Reviewers
Sqoop
sqoop-trunk
A patch implementing the Windows version of Sqoop run scripts. The scripts follow the same logic as there .sh counterparts.
One difference is to create a Jar which references all classpath elements in its Manifest, and provide that jar as the single jar needed for Sqoop. The reason here is that in some cases if the number of classpath elements is large, HADOOP_CLASSPATH gets very long which causes failures in Windows since there is a limit to command lines.
As a workaround, I added a step to wrap all jars in the classpath in a single jar, and then use that generated jar (this is also done in hadoop for Windows to handle similar issues)
I did this in a utility script "BuildJar" which can be used for other components as well.
This change is specific to Windows scripts, Linux scripts are not affected.

 
Review request changed
Updated (April 23, 2013, 4:13 a.m.)
Updating the scripts to print the missing variable name rather than the actual path for HADOOP_COMMON_HOME and HADOOP_MAPRED_HOME in case they refer to a path which does not exist.
Ship it!
Posted (April 23, 2013, 4:26 a.m.)
Looks good.  Thanks for the contribution Ahmed.
Ship it!
Posted (April 23, 2013, 6:38 p.m.)
Hi Ahmed, please attach the final patch version to the JIRA and I'll commit it.
  1. Done.
    Thank you.