Review Board 1.7.22


SQOOP-947 Introduce the concept of "sensitivity" input to all supported metadata structures

Review Request #10048 - Created March 20, 2013 and submitted

Abraham Elmahrek
SQOOP-947
Reviewers
Sqoop
jarcec, kate
sqoop-sqoop2
commit 64f2ddbf5654ea8bbcc47dc7cc4cabd6168c4fad
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Wed Mar 20 12:15:59 2013 -0700

    SQOOP-947 Introduce the concept of "sensitivity" input to all supported metadata structures

:100644 100644 8b40a54... 523f498... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
:100644 100644 e88216d... 80b10c8... M	common/src/main/java/org/apache/sqoop/model/FormUtils.java
:100644 100644 77598a8... 12705a6... M	common/src/main/java/org/apache/sqoop/model/MEnumInput.java
:100644 100644 96397e8... ea3d753... M	common/src/main/java/org/apache/sqoop/model/MInput.java
:100644 100644 d281d7e... d23ac31... M	common/src/main/java/org/apache/sqoop/model/MIntegerInput.java
:100644 100644 b458022... 704c1f8... M	common/src/main/java/org/apache/sqoop/model/MMapInput.java
:100644 100644 e96ec92... 16da76d... M	common/src/main/java/org/apache/sqoop/model/MStringInput.java
:100644 100644 85c65de... 08dfa7b... M	common/src/test/java/org/apache/sqoop/model/TestFormUtils.java
:100644 100644 1cde5cf... 4ea42b1... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
:100644 100644 a99b7dc... c3469ff... M	common/src/test/java/org/apache/sqoop/model/TestMConnection.java
:100644 100644 1d86c13... edaedb1... M	common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java
:100644 100644 b7b1356... 0bd55d9... M	common/src/test/java/org/apache/sqoop/model/TestMForm.java
:100644 100644 5f599eb... bd21fcb... M	common/src/test/java/org/apache/sqoop/model/TestMFormList.java
:100644 100644 042158a... 1f38e6d... M	common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java
:100644 100644 772f230... 1587147... M	common/src/test/java/org/apache/sqoop/model/TestMMapInput.java
:100644 100644 fa6b9ad... f336bab... M	common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java
:100644 100644 2ba9709... 7822ba5... M	common/src/test/java/org/apache/sqoop/model/TestMStringInput.java
:100644 100644 8d07521... 3fd5a95... M	common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java
:100644 100644 8af86b7... 486635d... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
Ran unit tests and integration tests.
Also performed requests with tcpdump to see if response and request JSON has "sensitive" key.
Added test case to test that sensitivity exists.

Diff revision 2 (Latest)

1 2
1 2

  1. client/src/main/java/org/apache/sqoop/client/core/Constants.java: Loading...
  2. client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java: Loading...
  3. client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java: Loading...
  4. client/src/main/resources/client-resource.properties: Loading...
  5. common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java: Loading...
  6. common/src/main/java/org/apache/sqoop/model/FormUtils.java: Loading...
  7. common/src/main/java/org/apache/sqoop/model/MEnumInput.java: Loading...
  8. common/src/main/java/org/apache/sqoop/model/MInput.java: Loading...
  9. common/src/main/java/org/apache/sqoop/model/MIntegerInput.java: Loading...
  10. common/src/main/java/org/apache/sqoop/model/MMapInput.java: Loading...
  11. common/src/main/java/org/apache/sqoop/model/MStringInput.java: Loading...
  12. common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java: Loading...
  13. common/src/test/java/org/apache/sqoop/model/TestFormUtils.java: Loading...
  14. common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java: Loading...
  15. common/src/test/java/org/apache/sqoop/model/TestMConnection.java: Loading...
  16. common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java: Loading...
  17. common/src/test/java/org/apache/sqoop/model/TestMForm.java: Loading...
  18. common/src/test/java/org/apache/sqoop/model/TestMFormList.java: Loading...
  19. common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java: Loading...
  20. common/src/test/java/org/apache/sqoop/model/TestMMapInput.java: Loading...
  21. common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java: Loading...
  22. common/src/test/java/org/apache/sqoop/model/TestMStringInput.java: Loading...
  23. common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java: Loading...
  24. repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java: Loading...
client/src/main/java/org/apache/sqoop/client/core/Constants.java
Revision cc80df108e2b2944fc31c9fba17b3639df663eec New Change
[20] 333 lines
[+20] [+] public class Constants {
334
      "formdisplayer.help";
334
      "formdisplayer.help";
335
  public static final String RES_FORMDISPLAYER_INPUT =
335
  public static final String RES_FORMDISPLAYER_INPUT =
336
      "formdisplayer.input";
336
      "formdisplayer.input";
337
  public static final String RES_FORMDISPLAYER_TYPE =
337
  public static final String RES_FORMDISPLAYER_TYPE =
338
      "formdisplayer.type";
338
      "formdisplayer.type";
339
  public static final String RES_FORMDISPLAYER_MASK =
339
  public static final String RES_FORMDISPLAYER_SENSITIVE =
340
      "formdisplayer.mask";
340
      "formdisplayer.sensitive";
341
  public static final String RES_FORMDISPLAYER_SIZE =
341
  public static final String RES_FORMDISPLAYER_SIZE =
342
      "formdisplayer.size";
342
      "formdisplayer.size";
343
  public static final String RES_FORMDISPLAYER_POSSIBLE_VALUES =
343
  public static final String RES_FORMDISPLAYER_POSSIBLE_VALUES =
344
      "formdisplayer.possible_values";
344
      "formdisplayer.possible_values";
345
  public static final String RES_FORMDISPLAYER_UNSUPPORTED_DATATYPE =
345
  public static final String RES_FORMDISPLAYER_UNSUPPORTED_DATATYPE =
346
      "formdisplayer.unsupported_datatype";
346
      "formdisplayer.unsupported_datatype";
347
  public static final String RES_FORMDISPLAYER_INPUT_SENSITIVE =
347
  public static final String RES_FORMDISPLAYER_INPUT_SENSITIVE =
348
      "formdisplayer.input_sensitive";
348
      "formdisplayer.input_sensitive";
349

    
   
349

   
350
  private Constants() {
350
  private Constants() {
351
    // Instantiation is prohibited
351
    // Instantiation is prohibited
352
  }
352
  }
353
}
353
}
client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java
Revision 0609ae103fd3b7bcd9b0a3d1a9063ccf542d9b5c New Change
 
client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java
Revision f11b9d29d3344c18f763fea3d15de794af325f08 New Change
 
client/src/main/resources/client-resource.properties
Revision 734333eebf147fc547d1d0664f00c63f72b81f70 New Change
 
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
Revision 3f8f985a150c9bb8a711cdb2f58b28e6035002c1 New Change
 
common/src/main/java/org/apache/sqoop/model/FormUtils.java
Revision e88216d6f11548b9d6b20ee5f76257c1f72c1128 New Change
 
common/src/main/java/org/apache/sqoop/model/MEnumInput.java
Revision 77598a820b50907c7d4410604e27cfd575d707cc New Change
 
common/src/main/java/org/apache/sqoop/model/MInput.java
Revision 96397e820e9f1075a37f1fffda52d3fd14cd9990 New Change
 
common/src/main/java/org/apache/sqoop/model/MIntegerInput.java
Revision d281d7efda9fcc0d265ee46601fd9529d8f2fdc4 New Change
 
common/src/main/java/org/apache/sqoop/model/MMapInput.java
Revision b4580221374b47ad1f64e4483a36abc6d8aac711 New Change
 
common/src/main/java/org/apache/sqoop/model/MStringInput.java
Revision e96ec929a5bdcabe03b61692d62ea8857ad0bade New Change
 
common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
Revision 5553554d8ba4c5d347e4984c36999a2ede295881 New Change
 
common/src/test/java/org/apache/sqoop/model/TestFormUtils.java
Revision 85c65de6dc6b2029307d66f5b7b54763c090edcb New Change
 
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
Revision 1cde5cf29bbfc1a9ffb08107c52f69aa0c109088 New Change
 
common/src/test/java/org/apache/sqoop/model/TestMConnection.java
Revision a99b7dc0009924ed4be6ada7fa8731fc4f6d9c0c New Change
 
common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java
Revision 1d86c132d4465773fb90e5ccc4d91fe4de40db07 New Change
 
common/src/test/java/org/apache/sqoop/model/TestMForm.java
Revision b7b1356edef9447cf80d9d07f3ecef7b2e5cb916 New Change
 
common/src/test/java/org/apache/sqoop/model/TestMFormList.java
Revision 5f599ebd93865c81b181044943ab44d69a8ddeab New Change
 
common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java
Revision 042158a8eabc3d2a2a41e0a3de5dda4e01517b36 New Change
 
common/src/test/java/org/apache/sqoop/model/TestMMapInput.java
Revision 772f230b17f22a829ba12a62425073c1d53b6895 New Change
 
common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java
Revision fa6b9ad805b02a1d67185091d3f65045af9e7993 New Change
 
common/src/test/java/org/apache/sqoop/model/TestMStringInput.java
Revision 2ba9709c014b8d4d7b59505234f36773ee85f195 New Change
 
common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java
Revision 8d0752194a3c7e37be4f3a316c851ea55348ee36 New Change
 
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
Revision 8af86b78f14ace5b440b610603e7031ca5117177 New Change
 
  1. client/src/main/java/org/apache/sqoop/client/core/Constants.java: Loading...
  2. client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java: Loading...
  3. client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java: Loading...
  4. client/src/main/resources/client-resource.properties: Loading...
  5. common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java: Loading...
  6. common/src/main/java/org/apache/sqoop/model/FormUtils.java: Loading...
  7. common/src/main/java/org/apache/sqoop/model/MEnumInput.java: Loading...
  8. common/src/main/java/org/apache/sqoop/model/MInput.java: Loading...
  9. common/src/main/java/org/apache/sqoop/model/MIntegerInput.java: Loading...
  10. common/src/main/java/org/apache/sqoop/model/MMapInput.java: Loading...
  11. common/src/main/java/org/apache/sqoop/model/MStringInput.java: Loading...
  12. common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java: Loading...
  13. common/src/test/java/org/apache/sqoop/model/TestFormUtils.java: Loading...
  14. common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java: Loading...
  15. common/src/test/java/org/apache/sqoop/model/TestMConnection.java: Loading...
  16. common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java: Loading...
  17. common/src/test/java/org/apache/sqoop/model/TestMForm.java: Loading...
  18. common/src/test/java/org/apache/sqoop/model/TestMFormList.java: Loading...
  19. common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java: Loading...
  20. common/src/test/java/org/apache/sqoop/model/TestMMapInput.java: Loading...
  21. common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java: Loading...
  22. common/src/test/java/org/apache/sqoop/model/TestMStringInput.java: Loading...
  23. common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java: Loading...
  24. repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java: Loading...