Review Board 1.7.22


SQOOP-958 Fix white space handling when generating version info

Review Request #10037 - Created March 20, 2013 and submitted

Abraham Elmahrek
SQOOP-958
Reviewers
Sqoop
jarcec, kate
sqoop-sqoop2
commit 6a7886a7f04428906ae7b99e86e22da30ec2fef2
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Tue Mar 19 17:29:06 2013 -0700

    SQOOP-958 Fix white space handling when generating version info
    
    When generating version info, white space in paths is not handled appropriately.

:100644 100644 2ab9073... 2921800... M	common/pom.xml
:100755 100755 31d3a33... 2fc7be4... M	common/src/saveVersion.sh
Ran 'mvn integration-test' with white space in build path.
Ran 'mvn package' with white space in build path.

Diff revision 1 (Latest)

  1. common/pom.xml: Loading...
  2. common/src/saveVersion.sh: Loading...
common/pom.xml
Revision 2ab9073 New Change
[20] 56 lines
[+20]
57
            </goals>
57
            </goals>
58
            <configuration>
58
            <configuration>
59
              <target>
59
              <target>
60
                <mkdir dir="${project.build.directory}/generated-sources/java"/>
60
                <mkdir dir="${project.build.directory}/generated-sources/java"/>
61
                <exec executable="sh">
61
                <exec executable="sh">
62
                  <arg line="${basedir}/src/saveVersion.sh ${project.version} ${project.build.directory}/generated-sources/java"/>
62
                  <arg line="'${basedir}/src/saveVersion.sh' ${project.version} '${project.build.directory}/generated-sources/java'"/>
63
                </exec>
63
                </exec>
64
              </target>
64
              </target>
65
            </configuration>
65
            </configuration>
66
          </execution>
66
          </execution>
67
        </executions>
67
        </executions>
[+20] [20] 34 lines
common/src/saveVersion.sh
Revision 31d3a33 New Change
 
  1. common/pom.xml: Loading...
  2. common/src/saveVersion.sh: Loading...